Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boosts are only inserted into the public timelines on page refresh #21

Open
neatchee opened this issue Dec 30, 2022 · 1 comment
Open
Assignees
Labels
bug Something isn't working lowpri Low priority issue

Comments

@neatchee
Copy link
Owner

Steps to reproduce the problem

  1. Enable the glitch-soc "show boosts in local timelines" feature
  2. On account A, make a post
  3. On account A, pull up the Local timeline
  4. In a separate browser session, on account B, boost the post from account A
  5. Do not refresh the page

Expected behaviour

Post appears in local timeline immediately when posted, and boost also appears immediately when boosted

Actual behaviour

Post appears in local timeline immediately when posted, but boost does not appear until the page is refreshed

Detailed description

Pretty straight-forward: posts are automatically inserted into the local timeline without a refresh, but boosts (and probably replies?) are not

Specifications

N/A - just build from neatchee/main

@neatchee neatchee added the bug Something isn't working label Dec 30, 2022
@neatchee neatchee added the lowpri Low priority issue label Dec 30, 2022
@deanveloper
Copy link
Collaborator

It looks like replies work fine, but boosts don't. Does this even work in glitch-soc? The broadcast_to_public_streams method (which i think is the only place that we redis.publish to timeline:public:...) never gets called on boosts, and I don't think I changed any logic on when that method gets called. I'll see what I can do to get boosts displaying over pubsub.

@deanveloper deanveloper changed the title Boosts and replies are only inserted into the public timelines on page refresh Boosts are only inserted into the public timelines on page refresh Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lowpri Low priority issue
Projects
None yet
Development

No branches or pull requests

2 participants