Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deep Profiling: remove captured patches when not used by any selected method #5

Open
marwie opened this issue Mar 18, 2021 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@marwie
Copy link
Member

marwie commented Mar 18, 2021

Currently when deep profiling the callstack is captured and enabled/disabled depending on any calling method being active

Example:
If we patch two different Update methods and one of them has a very large tree, then we remove the one with the large tree the nested calls (found via deep profiling) will still be enabled when we enable the method that does not really have those calls.

2021-03-18-130208.mp4
@marwie marwie added bug Something isn't working enhancement New feature or request labels Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant