Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should be minimumVal(root.right) #3272

Closed
MeganYTan opened this issue Feb 2, 2024 · 2 comments · Fixed by #3338
Closed

Should be minimumVal(root.right) #3272

MeganYTan opened this issue Feb 2, 2024 · 2 comments · Fixed by #3338

Comments

@MeganYTan
Copy link

leetcode/java/0450-delete-node-in-a-bst.java

Line 27 in 755a89a

TreeNode minVal = minimumVal(root);

This solution does not work. It should be minimumVal(root.right)
@a93a
Copy link
Collaborator

a93a commented Feb 7, 2024

That's true, good catch.

Do you want to open a PR with the change, or want me to change it for you ?

@Inamul07 Inamul07 mentioned this issue Mar 4, 2024
Merged
@Inamul07
Copy link
Contributor

Inamul07 commented Mar 5, 2024

@a93a I have made the changes relating to this issue, and i have also added two solutions in java, which were marked X in the ReadMe table. PR #3329

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update 0450-delete-node-in-a-bst.java Inamul07/leetcode
3 participants
@a93a @MeganYTan @Inamul07