Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating datasets with non-existing fileIDs should be impossible #1038

Open
2 tasks
MalinAhlberg opened this issue Sep 13, 2024 · 0 comments
Open
2 tasks

Creating datasets with non-existing fileIDs should be impossible #1038

MalinAhlberg opened this issue Sep 13, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@MalinAhlberg
Copy link
Contributor

MalinAhlberg commented Sep 13, 2024

THIS BUG HAS BEEN FIXED
Just verify that it works properly and if it is just close the issue

Describe the bug
It is possible to create a dataset with incorrect file IDs:

sda-admin dataset create --dataset-id dataset1 non-existing-id1 bad-id2

This could happen if the user for example mistypes an ID. sda-admin reports no error but the services starts to malfunction, and reports this on the following requests:

Error: failed to [...], reason: failed to send request, reason: Post "http://localhost:8090/file/accession": EOF

Steps to reproduce
sda-admin dataset create --dataset-id dataset1 non-existing-id1 bad-id2

A/C

  • Validate the files before mapping (if the file id exist) in sda-api

Expected behavior

Additional context
From #1026.

Estimation of size: medium

Estimation of priority: medium

@MalinAhlberg MalinAhlberg added the bug Something isn't working label Sep 13, 2024
@viklund viklund changed the title Creating datasets with non-existing fileIDs Creating datasets with non-existing fileIDs should be impossible Dec 6, 2024
@aaperis aaperis self-assigned this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants