fix: hotfix generate password #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanseto
force-pushed
the
jlc/fix-generate-password
branch
from
ffea89b to
3314e85
Compare
OmarIthawi
reviewed
Jul 22, 2024
| @@ -18,7 +18,7 @@ | |||
| from openedx.core.djangoapps.user_api.accounts.serializers import AccountUserSerializer | |||
| from openedx.core.djangolib.oauth2_retirement_utils import retire_dot_oauth2_models | |||
|
|
|||
| from edx_django_utils.user import generate_password # lint-amnesty, pylint: disable=wrong-import-order | |||
| from eox_nelp.user_authn.utils import generate_password # lint-amnesty, pylint: disable=wrong-import-order | |||
There was a problem hiding this comment.
Thanks @johanseto. Please check the comment on the original Palm upgrade pull request here:
Another option is to fork the edx_django_utils and create the change there instead of the patch.
Let me know what do you think.
|
Carried to prod in https://github.com/eduNEXT/eox-nelp/pull/208/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe what this pull request changes, and why. Include implications for people using this change.
Design decisions and their rationales should be documented in the repo (docstring / ADR), per
OEP-19, and can be
linked here.
Useful information to include:
"Developer", and "Operator".
changes.
Supporting information
Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.
Testing instructions
Please provide detailed step-by-step instructions for testing this change.
Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
Other information
Include anything else that will help reviewers and consumers understand the change.