Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filter by current site organizations #36

Merged

Conversation

andrey-canon
Copy link
Collaborator

Description

Limit API result to current organizations

Testing instructions

  1. Go to /api/mobile/v4/users/<username>/course_enrollments/ and check that the result doesn't contain any invalid organization

Deadline

"None" if there's no rush, or provide a specific date or event (and reason) if there is one.

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.
  • If your database migration can't be rolled back easily.

@andrey-canon andrey-canon force-pushed the and/filter_result_by_current_orgs branch from 623f0cd to da8ff07 Compare August 27, 2024 21:45
@andrey-canon andrey-canon requested a review from johanseto August 28, 2024 14:43
Copy link
Collaborator

@johanseto johanseto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems working. In only have some doubt related the count field one erollments because in the after shows me 0.
Also maybe is the difference from primary?

Before

2024-08-29_14-32

After

2024-08-29_14-27

@johanseto
Copy link
Collaborator

I tested with other tenant and yes, seem it count after the primary course_enrollment.
2024-08-29_14-47

@andrey-canon andrey-canon merged commit c6a6b05 into open-release/palm.nelp Aug 29, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants