Dev make apoc version aware #728
Conversation
gem-neo4j
force-pushed
the
dev_make_apoc_version_aware
branch
2 times, most recently
from
3b3dc49 to
4449e2d
Compare
gem-neo4j
force-pushed
the
dev_make_apoc_version_aware
branch
5 times, most recently
from
edc4600 to
97aca4d
Compare
| return procedureCallContext.calledwithQueryLanguage().equals(QueryLanguage.CYPHER_5) | ||
| ? "CYPHER 5 " | ||
| : "CYPHER 25 "; |
There was a problem hiding this comment.
When we release the next cypher version we will still run queries in Cypher 25, is that intentional?
There was a problem hiding this comment.
True true, I can make it more future safe
| } | ||
|
|
||
| public static String getCypherVersionString(ProcedureCallContext procedureCallContext) { | ||
| return procedureCallContext.calledwithQueryLanguage().equals(QueryLanguage.CYPHER_5) ? "5" : "25"; |
There was a problem hiding this comment.
Same here, will return "25" for newer versions.
| private static final Pattern CYPHER_VERSION_PATTERN = | ||
| Pattern.compile("^\\s*\\b(CYPHER)(?:\\s+(\\d+))?", Pattern.CASE_INSENSITIVE); | ||
| public static final Pattern PLANNER_PATTERN = | ||
| Pattern.compile("\\bplanner\\s*=\\s*[^\\s]*", Pattern.CASE_INSENSITIVE); | ||
| public static final Pattern RUNTIME_PATTERN = Pattern.compile("\\bruntime\\s*=", Pattern.CASE_INSENSITIVE); |
There was a problem hiding this comment.
We have access to the pre-parser, so potentially we could parse it out with that.
There was a problem hiding this comment.
Do we have an example of that in APOC somewhere already?
| } | ||
|
|
||
| private static final Pattern CYPHER_VERSION_PATTERN = | ||
| Pattern.compile("^\\s*\\b(CYPHER)(?:\\s+(\\d+))?", Pattern.CASE_INSENSITIVE); |
There was a problem hiding this comment.
What's \b in regex (I actually looked it up but still do not understand...).
There was a problem hiding this comment.
It makes sure that CYPHER is a single word by itself (so a string has to start with CYPHER and CYPHERS etc won't match)
| @Context | ||
| public ProcedureCallContext procedureCallContext; |
There was a problem hiding this comment.
I forgot, do ProcedureCallContext require allow unrestricted access?
There was a problem hiding this comment.
Yeah, it is marked as safe or whatever the terminology is :)
gem-neo4j
force-pushed
the
dev_make_apoc_version_aware
branch
from
758bf72 to
23eb6b1
Compare
Make APOC procedures and functions react based on used Cypher Version