Entity docs #171
Draft
Entity docs #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dennis C <[email protected]>
Co-authored-by: Dennis C <[email protected]>
Co-authored-by: ChampionAsh5357 <[email protected]>
neoforged-pages-deployments
bot
deployed
to
neoforged-docs-previews (Preview)
neoforged-pages-deployments
bot
deployed
to
neoforged-docs-previews (Preview)
neoforged-pages-deployments
bot
deployed
to
neoforged-docs-previews (Preview)
neoforged-pages-deployments
bot
deployed
to
neoforged-docs-previews (Preview)
neoforged-automation
bot
added
the
needs rebase
|
@IchHabeHunger54, this pull request has conflicts, please resolve them for this PR to move forward. |
# Conflicts: # docs/items/index.md # docs/items/interactionpipeline.md # docs/items/tools.md # docs/resources/server/enchantments/builtin.md
…DeferredSpawnEggItem
neoforged-automation
bot
removed
the
needs rebase
neoforged-pages-deployments
bot
deployed
to
neoforged-docs-previews (Preview)
neoforged-pages-deployments
bot
deployed
to
neoforged-docs-previews (Preview)
ChampionAsh5357
requested changes
Nov 21, 2024
| ```java | ||
| @Override | ||
| // The boolean return value determines whether the entity was actually damaged or not. | ||
| public boolean hurt(DamageSource damageSource, float amount) { |
There was a problem hiding this comment.
hurt is a final method, are you trying to refer to hurtServer and hurtClient? I'm guessing this was probably written before the 1.21.2 update.
|
|
||
| - `#tick`: This is the central tick method, and the one you will want to override in 99% of cases. | ||
| - By default, this forwards to `#baseTick`, however this is overridden by almost every subclass. | ||
| - `#baseTick`: This method handles updating some values common to all entities, including the "on fire" state, freezing from powder snow, the swimming state, and passing through portals. |
There was a problem hiding this comment.
When should I override baseTick then?
Comment on lines
+156
to
+158
| Natural spawning is performed every tick for entities where `MobCategory#isFriendly()` is true, and every 400 ticks (\= 20 seconds) for entities where `MobCategory#isFriendly()` is false. If `MobCategory#isPersistent()` returns true, this process additionally also happens on chunk generation. | ||
|
|
||
| For each chunk and mob category, it is checked whether there are less than `MobCategory#getMaxInstancesPerChunk() * loadedChunks / 289` in the world. Additionally, for each chunk, it is required that there are less than `MobCategory#getMaxInstancesPerChunk()` entities of that `MobCategory` near at least one player (near means that the distance between mob and player \<\= 128) for spawning of that `MobCategory` to occur. |
There was a problem hiding this comment.
I think the detail is good, but it is also very confusing to read and understand.
There was a problem hiding this comment.
I don't disagree, I just felt it was important to mention it here regardless, and I'm unsure how to improve this.
neoforged-pages-deployments
bot
deployed
to
neoforged-docs-previews (Preview)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some long-needed entity documentation. Supersedes #15 and #95 . Closes #90 . This PR:
This PR is a draft, and many sections are TODOs. Opening now for early feedback.
Preview URL: https://pr-171.neoforged-docs-previews.pages.dev