Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to AFTER ordering instead of NONE #186

Open
FiniteReality opened this issue Jul 21, 2024 · 3 comments
Open

Default to AFTER ordering instead of NONE #186

FiniteReality opened this issue Jul 21, 2024 · 3 comments

Comments

@FiniteReality
Copy link
Member

Related to neoforged/MDK#118

In most cases, a mod's dependencies DO actually need to be loaded before the mod in question is loaded - the current default of NONE means that our parallel construction can initialize a mod before its dependencies, leading to potential crashes due to thread timing nonsense. We should default to AFTER so that the typical use case is more likely to be correct, even if it does mean startup time is impacted slightly due to the strict ordering.

@Technici4n
Copy link
Member

I am against this change. Generally, there is no reason to reach for content of another mod within the same initialization phase.

@shartte
Copy link
Contributor

shartte commented Jul 21, 2024

In most cases, a mod's dependencies DO actually need to be loaded before the mod in question is loaded

Can you please back that up with some data? A ton of mods depend on JEI/EMI/REI/WTHIT/Jade where that is not correct.

@TelepathicGrunt
Copy link
Contributor

Do you have examples of said crashes? I rather we simply teach people of the ordering and they can use it when it actually matters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants