Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworked EarlyDisplay Texturing #258

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Reworked EarlyDisplay Texturing #258

wants to merge 5 commits into from

Conversation

shartte
Copy link
Contributor

@shartte shartte commented Mar 3, 2025

EarlyDisplay currently binds all its textures to the GL state at the same time. It essentially uses multi-texturing texturing units as "storage" for its texture handles.
This PR changes that so that only texturing unit 0 is used, and EarlyDisplay keeps track of the GL texture ids normally.
What it does NOT fix yet is the fact that EarlyDisplay never actually deletes the textures it creates.

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Mar 3, 2025

  • Publish PR to GitHub Packages

Last commit published: de740a6421a1707477b2235e40c5659e9ccb47fe.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #258' // https://github.com/neoforged/FancyModLoader/pull/258
        url 'https://prmaven.neoforged.net/FancyModLoader/pr258'
        content {
            includeModule('net.neoforged.fancymodloader', 'earlydisplay')
            includeModule('net.neoforged.fancymodloader', 'junit-fml')
            includeModule('net.neoforged.fancymodloader', 'loader')
            includeModule('net.neoforged.fancymodloader', 'tests')
        }
    }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants