Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy plugin for 1.17 to 1.20.1 #118

Merged
merged 24 commits into from
Dec 1, 2024
Merged

Legacy plugin for 1.17 to 1.20.1 #118

merged 24 commits into from
Dec 1, 2024

Conversation

shartte
Copy link
Collaborator

@shartte shartte commented Jul 29, 2024

Adds a separate net.neoforged.moddev.legacy plugin that lives in a different sourceset and can be used to develop for Minecraft and Forge 1.17 to 1.20.1.

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Jul 29, 2024

  • Publish PR to GitHub Packages

Last commit published: eebbfd7387ab4e6fe1a7995ac2b5b6ae13b59946.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #118' // https://github.com/neoforged/ModDevGradle/pull/118
        url 'https://prmaven.neoforged.net/ModDevGradle/pr118'
        content {
            includeModule('net.neoforged.moddev.legacyforge', 'net.neoforged.moddev.legacyforge.gradle.plugin')
            includeModule('net.neoforged', 'moddev-gradle')
            includeModule('net.neoforged.moddev.repositories', 'net.neoforged.moddev.repositories.gradle.plugin')
            includeModule('net.neoforged.moddev', 'net.neoforged.moddev.gradle.plugin')
        }
    }
}

@neoforged-automation
Copy link

@shartte, this pull request has conflicts, please resolve them for this PR to move forward.

@neoforged-automation neoforged-automation bot added the needs rebase This Pull Request needs to be rebased before being merged label Aug 13, 2024
@neoforged-automation neoforged-automation bot removed the needs rebase This Pull Request needs to be rebased before being merged label Sep 6, 2024
@Matyrobbrt Matyrobbrt marked this pull request as ready for review September 10, 2024 09:41
@Matyrobbrt Matyrobbrt changed the title Legacy Legacy plugin for 1.17 to 1.20.1 Sep 10, 2024
Copy link
Member

@Technici4n Technici4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not too bad. However, it is clear that this can only work as long as keep the toolchain essentially the same. When we will remove the legacy CP, this legacy plugin will go out of the window. This is also why I don't see this ever supporting 1.16. This raises the question of whether the plugin should exist in the same branch or not.

gradle/wrapper/gradle-wrapper.properties Outdated Show resolved Hide resolved
legacytest/build.gradle Outdated Show resolved Hide resolved
legacytest/forge/build.gradle Outdated Show resolved Hide resolved
legacytest/forge/build.gradle Outdated Show resolved Hide resolved
testproject/oldneo/build.gradle Outdated Show resolved Hide resolved
@neoforged-automation neoforged-automation bot added the needs rebase This Pull Request needs to be rebased before being merged label Oct 3, 2024
@neoforged-automation
Copy link

@shartte, this pull request has conflicts, please resolve them for this PR to move forward.

@shartte shartte force-pushed the legacy branch 2 times, most recently from 55c7be9 to 102b7bf Compare October 12, 2024 23:55
@neoforged-automation neoforged-automation bot removed the needs rebase This Pull Request needs to be rebased before being merged label Oct 12, 2024
@neoforged-automation neoforged-automation bot added the needs rebase This Pull Request needs to be rebased before being merged label Oct 13, 2024
@neoforged-automation
Copy link

@shartte, this pull request has conflicts, please resolve them for this PR to move forward.

@neoforged-automation neoforged-automation bot removed the needs rebase This Pull Request needs to be rebased before being merged label Oct 13, 2024
@neoforged-automation
Copy link

@shartte, this pull request has conflicts, please resolve them for this PR to move forward.

@neoforged-automation neoforged-automation bot added the needs rebase This Pull Request needs to be rebased before being merged label Oct 13, 2024
@pietro-lopes
Copy link

pietro-lopes commented Oct 26, 2024

I have been using this for a while and the only issue I found was with this setup when using a version of GregTech when it was built when they were still using ArchLoom.

https://github.com/pietro-lopes/mdg-legacy-pr118

Clone repo and run each of the 3 available runs: 1 failing, 2 working.

I noticed that their metadata.json lacks the info about if the jarjar is obfuscated or not, but I don't know if that alone is enough.

Edit: Can confirm that editing metadata.json takes no effect.

@neoforged-automation neoforged-automation bot removed the needs rebase This Pull Request needs to be rebased before being merged label Nov 29, 2024
@shartte
Copy link
Collaborator Author

shartte commented Nov 30, 2024

@pietro-lopes I tried with the official ForgeGradle MDK for 1.20.1 and depending on that version of Gregtech doesn't work there either. (Even after setting mixin.env.refMapRemappingFile, etc.)

@shartte shartte enabled auto-merge (squash) November 30, 2024 12:57
@Technici4n Technici4n merged commit 8748076 into main Dec 1, 2024
6 checks passed
@Technici4n Technici4n deleted the legacy branch December 1, 2024 19:35
@neoforged-releases
Copy link

🚀 This PR has been released as ModDevGradle version 2.0.50-beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants