-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Legacy plugin for 1.17 to 1.20.1 #118
Conversation
Last commit published: eebbfd7387ab4e6fe1a7995ac2b5b6ae13b59946. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #118' // https://github.com/neoforged/ModDevGradle/pull/118
url 'https://prmaven.neoforged.net/ModDevGradle/pr118'
content {
includeModule('net.neoforged.moddev.legacyforge', 'net.neoforged.moddev.legacyforge.gradle.plugin')
includeModule('net.neoforged', 'moddev-gradle')
includeModule('net.neoforged.moddev.repositories', 'net.neoforged.moddev.repositories.gradle.plugin')
includeModule('net.neoforged.moddev', 'net.neoforged.moddev.gradle.plugin')
}
}
} |
@shartte, this pull request has conflicts, please resolve them for this PR to move forward. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not too bad. However, it is clear that this can only work as long as keep the toolchain essentially the same. When we will remove the legacy CP, this legacy plugin will go out of the window. This is also why I don't see this ever supporting 1.16. This raises the question of whether the plugin should exist in the same branch or not.
src/legacy/java/net/neoforged/moddevgradle/legacy/MixinExtension.java
Outdated
Show resolved
Hide resolved
src/main/java/net/neoforged/moddevgradle/internal/RunUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/net/neoforged/moddevgradle/internal/RunUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/net/neoforged/moddevgradle/internal/UserDevConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/net/neoforged/moddevgradle/internal/ModDevPlugin.java
Outdated
Show resolved
Hide resolved
@shartte, this pull request has conflicts, please resolve them for this PR to move forward. |
55c7be9
to
102b7bf
Compare
@shartte, this pull request has conflicts, please resolve them for this PR to move forward. |
src/legacy/java/net/neoforged/moddevgradle/legacy/LegacyForgeMetadataTransform.java
Outdated
Show resolved
Hide resolved
@shartte, this pull request has conflicts, please resolve them for this PR to move forward. |
I have been using this for a while and the only issue I found was with this setup when using a version of GregTech when it was built when they were still using ArchLoom. https://github.com/pietro-lopes/mdg-legacy-pr118 Clone repo and run each of the 3 available runs: 1 failing, 2 working. I noticed that their metadata.json lacks the info about if the jarjar is obfuscated or not, but I don't know if that alone is enough. Edit: Can confirm that editing metadata.json takes no effect. |
Co-authored-by: Matyrobbrt <[email protected]>
@pietro-lopes I tried with the official ForgeGradle MDK for 1.20.1 and depending on that version of Gregtech doesn't work there either. (Even after setting mixin.env.refMapRemappingFile, etc.) |
src/legacy/java/net/neoforged/moddevgradle/legacy/LegacyModDevPlugin.java
Outdated
Show resolved
Hide resolved
src/main/java/net/neoforged/moddevgradle/internal/RunUtils.java
Outdated
Show resolved
Hide resolved
🚀 This PR has been released as ModDevGradle version |
Adds a separate
net.neoforged.moddev.legacy
plugin that lives in a different sourceset and can be used to develop for Minecraft and Forge 1.17 to 1.20.1.