Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client Data runs crash when requiring an OpenGL context higher than vanilla #1956

Open
ChampionAsh5357 opened this issue Feb 12, 2025 · 0 comments
Labels
1.21.4 Targeted at Minecraft 1.21.4 bug A bug or error

Comments

@ChampionAsh5357
Copy link
Contributor

Minecraft Version: Tested 1.21.4

NeoForge Version: Tested 24.0+

Steps to Reproduce:

  1. Set the openGLVersion in a neoforge.mods.toml to a value or range that does not include the vanilla default (version 3.2).
modLoader="javafml"
loaderVersion="[4,)"
license="All Rights Reserved"

[[mods]]
modId="examplemod"
version="1.0.0"
displayName="Example Mod"
description='''Example mod'''

[features.examplemod]
openGLVersion="[4,)"
  1. Use a run configuration that doesn't open the early window screen with a launch handler that uses Dist#CLIENT (e.g. runClientData)

  2. The game crashes

Description of issue: The OpenGL version is updated through the early window control, which sets the highest GL context available on the current machine. This dependency is checked as long as the current side is on the client. For client runs, this is fine as the early window control is enabled by default through the fml.toml. However, client data runs do not use the early window control, as there is no need to. Since the client data is considered to be run on the physical client, the feature is also checked, causing a crash to occur.

Basically, openGLVersion should only be checked for the client runs and not any data runs.

@ChampionAsh5357 ChampionAsh5357 added 1.21.4 Targeted at Minecraft 1.21.4 bug A bug or error labels Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.4 Targeted at Minecraft 1.21.4 bug A bug or error
Projects
None yet
Development

No branches or pull requests

1 participant