Fix milk bucket curing effects before advancement trigger #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sciwhiz12
added
bug
|
This one needs updating to 20.2 too 😄 |
|
Updated to 1.20.2 and re-tested |
Technici4n
approved these changes
Nov 10, 2023
Gaming32
added a commit
to Gaming32/bingo
that referenced
this pull request
Nov 10, 2023
Xing-C
added a commit
to Xing-C/NeoForge
that referenced
this pull request
Dec 4, 2023
…oforged#170)" This reverts commit ef633ca.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue
Forge moves the effect curing call in
MilkBucketItem#finishUsingItemto the method's head, in order to use the stack's properties before it is emptied. However, the method call also comes before the item use advancement trigger, which prevents it from being used in combination with advancement criterions that check for the user's active effects.Here's the advancement I used to test this behavior. It is supposed to trigger when the player consumes milk with the nausea effect active.
The solution
We move the method call to
curePotionEffectsafter the advancement trigger so that it meets both of our criteria - allowing the advancement to run and still being able to access the stack in the effect curing method.Fixes #151