[1.20.2] Fix ObjLoader leaking and using outdated ResourceManager #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technici4n
approved these changes
Oct 30, 2023
sciwhiz12
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the ObjLoader caching the wrong ResourceManager at the end of every reload, leading to an outdated one being used on any subsequent reload, instead of always using the "root" ResourceManager stored in Minecraft.
Fixes #162
Also included is a fix to the way the OBJ model calculates texture coordinates as the UV getters in
TextureAtlasSpritewere changed to take values between 0 and 1 instead of 0 and 16.