Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples/button/Base: opening the menu list does no longer allow using the arrow keys to navigate right away #6033

Open
tobiu opened this issue Oct 15, 2024 · 3 comments
Assignees
Labels
bug Something isn't working epic A big time intense ticket with related sub-tasks

Comments

@tobiu
Copy link
Collaborator

tobiu commented Oct 15, 2024

  • looks like a regression bug to me. might be related to the main.addon.Navigator introduction
  • most likely just a missing focus() call
@tobiu tobiu added the bug Something isn't working label Oct 15, 2024
@tobiu tobiu self-assigned this Oct 15, 2024
@soumajit23
Copy link

Hello @tobiu , I would like to work on this issue.

@tobiu
Copy link
Collaborator Author

tobiu commented Oct 18, 2024

hi @soumajit23,

while contributions are welcome, i am afraid that this ticket is way too difficult for a first item to work on. you could easily spend a full week on it, since it requires in depth knowledge about the framework mechanics and change history.

My first thought was that it is related to @ThorstenRaab's commit, where he removed the focus() call when showing the button menu:
342afbb#diff-e2256fc11cf65d84943c3bd398132cb7e134ddba3a4af65cda9234874bf93b58R547

(i have no clue why this commit had no ticket and description, since it did breaks things)

digging deeper, it is definitely also related to @ExtAnimal's changes on selection models (separating selections and focus of items).

best regards,
tobias

@tobiu tobiu added the epic A big time intense ticket with related sub-tasks label Oct 18, 2024
@soumajit23
Copy link

@tobiu thank you for clarifying! Looking into it, I see that it is definitely quite difficult to work on. I suppose I will look into other issues to work on for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working epic A big time intense ticket with related sub-tasks
Projects
None yet
Development

No branches or pull requests

2 participants