Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pageserver: eliminate 500 cases during timeline creation/deletion #9768

Open
jcsp opened this issue Nov 15, 2024 · 0 comments
Open

pageserver: eliminate 500 cases during timeline creation/deletion #9768

jcsp opened this issue Nov 15, 2024 · 0 comments

Comments

@jcsp
Copy link
Collaborator

jcsp commented Nov 15, 2024

Problem

Some code paths munge cancellation errors into anyhow::Error and consequently surface it as a 500 in the HTTP API.

Impact

These 500s make it harder to alert on a produciton system and risk hiding real issues: 500s should be reserved for unexpected situations, whereas deleting a timeline on a tenant that's migrating (shutting down) is expected during migrations (e.g. during a deploy)

In test_timeline_archival_chaos we have allow lists like this:

    env.storage_controller.allowed_errors.extend(
        [
            ".*error sending request.*",
            # FIXME: the pageserver should not return 499s on cancellation
            ".*InternalServerError(Error deleting timeline .* on .* on .*: pageserver API: error: Cancelled",
        ]
    )

    for ps in env.pageservers:
        # We will do unclean restarts, which results in these messages when cleaning up files
        ps.allowed_errors.extend(
            [
                ".*removing local file.*because it has unexpected length.*",
                ".*__temp.*",
                # FIXME: there are still anyhow::Error paths in timeline creation/deletion which
                # generate 499 results when called during shutdown
                ".*InternalServerError.*",
                # FIXME: there are still anyhow::Error paths in timeline deletion that generate
                # log lines at error severity
                ".*delete_timeline.*Error",
            ]
        )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant