New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: use `#[tokio::test(start_paused=true)]` to avoid flakiness in the future #62

Open

problame opened this issue Oct 29, 2024 · 0 comments

Labels

Collaborator

problame commented Oct 29, 2024

tokio-epoll-uring/tokio-epoll-uring/src/system/tests.rs

Lines 403 to 406 in 781989b

    
           /// NB: In this test, we use the pattern of `select! { ..., sleep(2 seconds) }` to drive op futures 
        
           /// to the point where they are enqueued and occupy a slot. This will become flaky if that takes 
        
           /// more than 2 seconds. A more deterministic way to do it would be to use 
        
           /// #[tokio::test(start_paused=true)].

tokio-epoll-uring/tokio-epoll-uring/src/system/tests.rs

Lines 317 to 320 in 781989b

    
           /// NB: In this test, we use the pattern of `select! { ..., sleep(2 seconds) }` to drive op futures 
        
           /// to the point where they are enqueued and occupy a slot. This will become flaky if that takes 
        
           /// more than 2 seconds. A more deterministic way to do it would be to use 
        
           /// #[tokio::test(start_paused=true)].

problame added the tech_debt label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment