Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX Fusion lazy props cause wrong lastEvaluationStatus #4500

Draft
wants to merge 1 commit into
base: 7.3
Choose a base branch
from
Draft

BUGFIX Fusion lazy props cause wrong lastEvaluationStatus #4500

wants to merge 1 commit into from

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Sep 11, 2023 •
edited
Loading

Resolves #4499

WIP Needs test!

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@mhsdesign mhsdesign changed the title BUGFIX Fusion lazy props cause wrong lastEvaluationStatus in BUGFIX Fusion lazy props cause wrong lastEvaluationStatus Sep 11, 2023
@github-actions github-actions bot added the 7.3 label Sep 11, 2023
@mhsdesign mhsdesign marked this pull request as draft September 11, 2023 08:03
@mhsdesign mhsdesign marked this pull request as ready for review September 27, 2023 07:02
@ahaeslich
Copy link
Member

@mhsdesign the description says

WIP Needs test!

Do you still plan to add some?

@mhsdesign
Copy link
Member Author

Yes but not atm ^^ But we should do it to prevent a regression.

bwaidelich
bwaidelich reviewed Oct 30, 2023
View reviewed changes
Copy link
Member

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ticket description says

WIP Needs test!

and i agree to it :)

@mficzel
Copy link
Member

mficzel commented Oct 30, 2023

Will look into with @mhsdesign

@mhsdesign mhsdesign marked this pull request as draft February 2, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwaidelich bwaidelich bwaidelich left review comments

@Sebobo Sebobo Sebobo approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
7.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mhsdesign @ahaeslich @mficzel @bwaidelich @Sebobo