Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Remove legacy NodeAddress and NodeAddressFactory #5267

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Sep 26, 2024

Neos Ui adjustments neos/neos-ui#3858
Fixes final parts of #4564

As bitterly debated in #5072 we will change the serialisation format of the CR Node in URLS and in the Neos UI.

Currently there is a big legacy corruption layer around the WorkspaceModule, NeosUi and the Nodes controller using the ancient Legacy NodeAddress and NodeAddressFactory to work with the legacy format. This is part of the migration strategy and will be cleaned up in this change.

For reference the Neos Ui's content node serialisation:

- Neos 8.3
onedimension.localhost:8081/neos/content?node=/sites/neos-test-site@user-admin;language=en_US

- Neos 9.0-dev (currently)
onedimension.localhost:8081/neos/content?node=user-admin__eyJsYW5ndWFnZSI6ImVuX1VTIn0=__f676459d-ca77-44bc-aeea-44114814c279

- Neos 9.0 next beta, this pr
onedimension.localhost:8081/neos/content?node={"contentRepositoryId":"onedimension","workspaceName":"user-admin","dimensionSpacePoint":{"language":"en_US"},"aggregateId":"000b42ff-c9d3-4b5e-b6de-56d35832dc0e"}

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@mhsdesign mhsdesign changed the title TASK: Remove usages to NodeAddressFactory TASK: Remove legacy NodeAddress and NodeAddressFactory Sep 26, 2024
@mhsdesign mhsdesign force-pushed the task/migrate-to-json-node-address branch from 83dda75 to 7e99114 Compare October 9, 2024 14:41
@mhsdesign mhsdesign force-pushed the task/migrate-to-json-node-address branch from 7e99114 to 875d575 Compare October 14, 2024 08:11
Copy link
Contributor

@pKallert pKallert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it locally and works fine as far as I can see 👍

Copy link
Member

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@kitsunet kitsunet merged commit 263966a into neos:9.0 Oct 16, 2024
9 checks passed
@mhsdesign mhsdesign deleted the task/migrate-to-json-node-address branch October 16, 2024 07:46
@mhsdesign
Copy link
Member Author

Thanks for the reviews <3
I also merged the Neos Ui adjustments: neos/neos-ui#3858

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants