-
-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TASK: Remove legacy NodeAddress
and NodeAddressFactory
#5267
Merged
kitsunet
merged 1 commit into
neos:9.0
from
mhsdesign:task/migrate-to-json-node-address
Oct 16, 2024
Merged
TASK: Remove legacy NodeAddress
and NodeAddressFactory
#5267
kitsunet
merged 1 commit into
neos:9.0
from
mhsdesign:task/migrate-to-json-node-address
Oct 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhsdesign
changed the title
TASK: Remove usages to
TASK: Remove legacy Sep 26, 2024
NodeAddressFactory
NodeAddress
and NodeAddressFactory
mhsdesign
commented
Oct 8, 2024
mhsdesign
commented
Oct 8, 2024
pKallert
reviewed
Oct 8, 2024
mhsdesign
force-pushed
the
task/migrate-to-json-node-address
branch
from
October 9, 2024 14:41
83dda75
to
7e99114
Compare
mhsdesign
force-pushed
the
task/migrate-to-json-node-address
branch
from
October 14, 2024 08:11
7e99114
to
875d575
Compare
pKallert
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it locally and works fine as far as I can see 👍
bwaidelich
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
kitsunet
approved these changes
Oct 16, 2024
Thanks for the reviews <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neos Ui adjustments neos/neos-ui#3858
Fixes final parts of #4564
As bitterly debated in #5072 we will change the serialisation format of the CR Node in URLS and in the Neos UI.
Currently there is a big legacy corruption layer around the WorkspaceModule, NeosUi and the Nodes controller using the ancient Legacy NodeAddress and NodeAddressFactory to work with the legacy format. This is part of the migration strategy and will be cleaned up in this change.
For reference the Neos Ui's content node serialisation:
Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX
!!!
and have upgrade-instructions