-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: Integrate conflict resolution with publish/discard dialog workflow #3769
FEATURE: Integrate conflict resolution with publish/discard dialog workflow #3769
Commits on Jun 28, 2024
-
TASK: Move
Conflicts
concept toApplication\Shared
namespaceThis moves the classes `ConflictsOccurred`, `Conflict`, `Conflicts`, `ConflictsBuilder`, `ReasonForConflict`, `TypeOfChange` and `IconLabel` into the `Application\Shared` namespace and adjusts all references accordingly. These classes are going to be reused by multiple command handlers.
Configuration menu - View commit details
-
Copy full SHA for aaeb68a - Browse repository at this point
Copy the full SHA aaeb68aView commit details -
TASK: Add command handlers for all Publish-related commands
This includes the following tasks; - Move `PublishChangesInDocument` -> `PublishChangesInDocument\PublishChangesInDocumentCommand` - Create `PublishChangesInDocumentCommandHandler` - Move `PublishChangesInSite` -> `PublishChangesInSite\PublishChangesInSiteCommand` - Create `PublishChangesInSiteCommandHandler`
Configuration menu - View commit details
-
Copy full SHA for 5ff99a8 - Browse repository at this point
Copy the full SHA 5ff99a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 10c0098 - Browse repository at this point
Copy the full SHA 10c0098View commit details -
Configuration menu - View commit details
-
Copy full SHA for 852bad1 - Browse repository at this point
Copy the full SHA 852bad1View commit details -
TASK: Move logic to create Conflicts from WorkspaceRebaseFailed into …
…dedicated Factory
Configuration menu - View commit details
-
Copy full SHA for aec75b0 - Browse repository at this point
Copy the full SHA aec75b0View commit details -
TASK: Use conflict DTO
key
property as key for iteration in Conflic……tList component
Configuration menu - View commit details
-
Copy full SHA for 67468b3 - Browse repository at this point
Copy the full SHA 67468b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 24927dc - Browse repository at this point
Copy the full SHA 24927dcView commit details -
BUGFIX: Remove race condition in
watchNodeInformationChanges
It may happen that `fetchAdditionalNodeMetadata` adds metadata for a node that has since been removed from the store. The occurance of such "zombie" nodes leads to problems, because they may lack crucial properties like `children` that are treated as always- present by other mechanisms throughout the UI. This became apparent after #3756. The CR.Nodes.MERGE action now takes care of preventing zombie nodes from entering the store.
Configuration menu - View commit details
-
Copy full SHA for f23176b - Browse repository at this point
Copy the full SHA f23176bView commit details -
BUGFIX: Wait and reload before syncing in E2E test
This is to prevent the flakiness described in #3785.
Configuration menu - View commit details
-
Copy full SHA for 4205f09 - Browse repository at this point
Copy the full SHA 4205f09View commit details -
Configuration menu - View commit details
-
Copy full SHA for 98d002a - Browse repository at this point
Copy the full SHA 98d002aView commit details -
BUGFIX: Fix undefined state when cancelling sync operations
This adds an e2e test case for cancelling and reselecting a resolution strategy and another e2e test case for immediate resolution cancellation. Both test cases are fixed by changes to the syncing saga.
Configuration menu - View commit details
-
Copy full SHA for d8c93a0 - Browse repository at this point
Copy the full SHA d8c93a0View commit details -
TASK: Handle edge case when automatic syncing during "publish documen…
…t" removes the document This also adds two more E2E test cases for publishing with automatic syncing.
Configuration menu - View commit details
-
Copy full SHA for f2526fd - Browse repository at this point
Copy the full SHA f2526fdView commit details
Commits on Sep 30, 2024
-
Merge remote-tracking branch 'origin/9.0' into feature/conflict-resol…
…ution-03/rebase-during-publish
Configuration menu - View commit details
-
Copy full SHA for e0bcbd1 - Browse repository at this point
Copy the full SHA e0bcbd1View commit details -
Configuration menu - View commit details
-
Copy full SHA for c7c160f - Browse repository at this point
Copy the full SHA c7c160fView commit details
Commits on Oct 17, 2024
-
Merge remote-tracking branch 'origin/9.0' into feature/conflict-resol…
…ution-03/rebase-during-publish
Configuration menu - View commit details
-
Copy full SHA for b072764 - Browse repository at this point
Copy the full SHA b072764View commit details -
Configuration menu - View commit details
-
Copy full SHA for 64ac4bc - Browse repository at this point
Copy the full SHA 64ac4bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c70968 - Browse repository at this point
Copy the full SHA 9c70968View commit details
Commits on Oct 26, 2024
-
Merge remote-tracking branch 'origin/9.0' into feature/conflict-resol…
…ution-03/rebase-during-publish
Configuration menu - View commit details
-
Copy full SHA for d3090d4 - Browse repository at this point
Copy the full SHA d3090d4View commit details
Commits on Oct 27, 2024
-
TASK: Make sure e2e test fail if the Publish Result Dialog shows an e…
…rror Currently, the `#neos-PublishDialog-Acknowledge` id will be used both for the "ok" button in success, and for the "cancel" button in case of any unexpected errors. To make the e2e tests fail fast we change the id in the error case to `Acknowledge-Error` so we dont accidentally click it. see also: #3769 (review)
Configuration menu - View commit details
-
Copy full SHA for 6778a5a - Browse repository at this point
Copy the full SHA 6778a5aView commit details -
Configuration menu - View commit details
-
Copy full SHA for d2baeb7 - Browse repository at this point
Copy the full SHA d2baeb7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7468ffb - Browse repository at this point
Copy the full SHA 7468ffbView commit details
Commits on Oct 28, 2024
-
TASK: Avoid use of internal
sequenceNumber
for building commands th……at failed instead we can just generate a uuid as the `sequenceNumber` was also unique for each command that failed see neos/neos-development-collection#5301 (comment)
Configuration menu - View commit details
-
Copy full SHA for 15c13ab - Browse repository at this point
Copy the full SHA 15c13abView commit details -
Configuration menu - View commit details
-
Copy full SHA for 36a5de7 - Browse repository at this point
Copy the full SHA 36a5de7View commit details
Commits on Oct 29, 2024
-
Merge remote-tracking branch 'origin/9.0' into feature/conflict-resol…
…ution-03/rebase-during-publish
Configuration menu - View commit details
-
Copy full SHA for 68fdde5 - Browse repository at this point
Copy the full SHA 68fdde5View commit details