BUGFIX: Fix hidden state evaluation #3867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Neos 8.3 LinkingService contained this logic ``` $action = $node->getContext()->getWorkspace()->isPublicWorkspace() && !$node->isHidden() ? 'show' : 'preview'; ``` ensuring that disabled nodes can still be previewed. In Neos 9 a no route matched error will be thrown. To restore the old behaviour we evaluate the hidden state
mhsdesign
added a commit
to mhsdesign/neos-development-collection
that referenced
this pull request
Oct 14, 2024
…uri builder behaviour This was accidentally wrongly migrated. Regarding > Why do we evaluate the hidden state here? We dont do it in the new uri builder. We dont evaluate the hidden state in the new uri builder because we only have the node address at hand. The 8.3 logic ``` $action = $node->getContext()->getWorkspace()->isPublicWorkspace() && !$node->isHidden() ? 'show' : 'preview'; ``` Ensured if youre routing to a hidden live node then a preview uri will be built. This is mostly unlikely going to happen and building the preview uri in this case is possibly not even the desired behaviour One exception, in the Neos.Ui requires this behaviour: neos/neos-ui#3867
neos-bot
pushed a commit
to neos/neos
that referenced
this pull request
Oct 14, 2024
…uri builder behaviour This was accidentally wrongly migrated. Regarding > Why do we evaluate the hidden state here? We dont do it in the new uri builder. We dont evaluate the hidden state in the new uri builder because we only have the node address at hand. The 8.3 logic ``` $action = $node->getContext()->getWorkspace()->isPublicWorkspace() && !$node->isHidden() ? 'show' : 'preview'; ``` Ensured if youre routing to a hidden live node then a preview uri will be built. This is mostly unlikely going to happen and building the preview uri in this case is possibly not even the desired behaviour One exception, in the Neos.Ui requires this behaviour: neos/neos-ui#3867
bwaidelich
changed the title
bwaidelich
reviewed
Oct 15, 2024
|
|
||
| $nodeAddressInBaseWorkspace = NodeAddress::create( | ||
| $nodeAddress->contentRepositoryId, | ||
| $workspace->baseWorkspaceName ?? WorkspaceName::forLive(), |
There was a problem hiding this comment.
If the selected workspace has no base workspace – shouldn't that be an error?
There was a problem hiding this comment.
i this is like one of these if ($siteNode) {} calls that are just there to prevent an error than to run into a fatal error.
If some logic is changed that we for example work on the live workspace directly we should also still be able to preview it ... but i think youre right ... for that case $workspace->baseWorkspaceName ?? $workspace->workspaceName should be enough;)
…ction-for-disabled-nodes-in-base-live-workspace
remove logic of falling back to live workspace, but use the original workspace then instead.
bwaidelich
reviewed
Oct 16, 2024
Co-authored-by: Bastian Waidelich <[email protected]>
bwaidelich
approved these changes
Oct 16, 2024
mhsdesign
deleted the
bugfix/fix-redirectToAction-for-disabled-nodes-in-base-live-workspace
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Neos 8.3 LinkingService contained this logic
ensuring that disabled nodes can still be previewed. In Neos 9 a no route matched error will be thrown.
To restore the old behaviour we evaluate the hidden state
What I did
How I did it
How to verify it