Ckeditor upgrade #3879
Open
Ckeditor upgrade #3879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configuration/Settings.yaml
Outdated
| @@ -94,7 +94,7 @@ Neos: | |||
| ################################# | |||
| # INTERNAL CONFIG (no API) | |||
| ################################# | |||
| frontendDevelopmentMode: false | |||
| frontendDevelopmentMode: true | |||
There was a problem hiding this comment.
Here you accidentally committed a config. BTW, you can create a config file in your project and change the setting there instead of changing it in the package itself ;)
There was a problem hiding this comment.
Thanks :). I removed the change from the PR.
packages/neos-ui/package.json
Outdated
| "@fortawesome/free-regular-svg-icons": "^5.15.3", | ||
| "@fortawesome/free-solid-svg-icons": "^5.15.3", | ||
| "@ckeditor/ckeditor5-highlight": "42.0.2", | ||
| "@fortawesome/fontawesome-svg-core": "^6.5.2", |
There was a problem hiding this comment.
Is it intended that you upgrade CKEditor and font awesome at once?
There was a problem hiding this comment.
Removed the fontawesome update :).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I increased the CKEditor5 version to 42.0.2 from version 16.0.0.
Also I fixed small build-errors, which occured by upgrading the CKEditor packages.
** How I did it**
How to verify it
Checkout the PR and use the Neos backend.
Already tested Plugins: