BUGIFX: Show hidden state only for directly disabled nodes without inheritance #3880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nezaniel
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix the display of the hidden state in the content and document tree was broken. Initially only directly disabled nodes where marked as hidden. After opening a document node below a directly disabled node the icon of the selected node has changed also to "hidden".
In Neos <9 we only show disabled nodes with the "hidden" indicator and not the children. So this change ensures the same behavior as before.
In future we should think about a new indicator, which shows a "nodes hidden/disabled by inheritance" state.
Before:
Now:
