From 06f440ef7ffce46e3569cc3b818d8c0673d0bb99 Mon Sep 17 00:00:00 2001
From: Gina Wu <ginawu98@gmail.com>
Date: Mon, 17 Jun 2024 22:20:22 -0700
Subject: [PATCH] changes

---
 examples/24_notification.py                 | 5 ++---
 src/viser/_gui_api.py                       | 8 ++++----
 src/viser/_gui_handles.py                   | 2 +-
 src/viser/_messages.py                      | 4 ++--
 src/viser/client/src/WebsocketInterface.tsx | 4 ++--
 src/viser/client/src/WebsocketMessages.tsx  | 4 ++--
 6 files changed, 13 insertions(+), 14 deletions(-)

diff --git a/examples/24_notification.py b/examples/24_notification.py
index 1f34dc424..514b4d427 100644
--- a/examples/24_notification.py
+++ b/examples/24_notification.py
@@ -19,11 +19,10 @@ def _(_) -> None:
         notif = server.gui.add_notification(
             title="Notification",
             body="You have clicked a button!",
-            withCloseButton=True,
+            with_close_button=True,
             loading=False,
-            autoClose=2000,
+            auto_close=2000,
         )
-        notif.show()
 
     @clear_button.on_click
     def _(_) -> None:
diff --git a/src/viser/_gui_api.py b/src/viser/_gui_api.py
index c6af68b1e..172428125 100644
--- a/src/viser/_gui_api.py
+++ b/src/viser/_gui_api.py
@@ -874,9 +874,9 @@ def add_notification(
         self,
         title: str,
         body: str,
-        withCloseButton: bool,
+        with_close_button: bool,
         loading: bool,
-        autoClose: int | bool = False,
+        auto_close: int | Literal[False],
     ) -> GuiNotificationHandle:
         """Add a notification, which can be toggled on/off in the GUI.
 
@@ -895,9 +895,9 @@ def add_notification(
             notification=_messages.NotificationMessage(
                 title=title,
                 body=body,
-                withCloseButton=withCloseButton,
+                withCloseButton=with_close_button,
                 loading=loading,
-                autoClose=autoClose,
+                autoClose=auto_close,
             ),
         )
 
diff --git a/src/viser/_gui_handles.py b/src/viser/_gui_handles.py
index 7fec13581..4d910c6ee 100644
--- a/src/viser/_gui_handles.py
+++ b/src/viser/_gui_handles.py
@@ -312,7 +312,7 @@ class GuiNotificationHandle:
     gui_api: GuiApi
     notification: NotificationMessage
 
-    def show(self):
+    def __post_init__(self) -> None:
         self.gui_api._websock_interface.queue_message(self.notification)
 
 
diff --git a/src/viser/_messages.py b/src/viser/_messages.py
index a8810ddcb..49a7437ed 100644
--- a/src/viser/_messages.py
+++ b/src/viser/_messages.py
@@ -86,9 +86,9 @@ class NotificationMessage(Message):
 
     title: str
     body: str
-    withCloseButton: bool
+    with_close_button: bool
     loading: bool
-    autoClose: Union[int, bool]
+    auto_close: Union[int, Literal[False]]
 
 
 @dataclasses.dataclass
diff --git a/src/viser/client/src/WebsocketInterface.tsx b/src/viser/client/src/WebsocketInterface.tsx
index e8a3f9fdd..f5a3b4d1a 100644
--- a/src/viser/client/src/WebsocketInterface.tsx
+++ b/src/viser/client/src/WebsocketInterface.tsx
@@ -142,9 +142,9 @@ function useMessageHandler() {
           // id: notificationId,
           title: message.title,
           message: message.body,
-          withCloseButton: message.withCloseButton,
+          withCloseButton: message.with_close_button,
           loading: message.loading,
-          autoClose: message.autoClose,
+          autoClose: message.auto_close,
           });
         return;
       }
diff --git a/src/viser/client/src/WebsocketMessages.tsx b/src/viser/client/src/WebsocketMessages.tsx
index 1988109c1..bd2a68eb1 100644
--- a/src/viser/client/src/WebsocketMessages.tsx
+++ b/src/viser/client/src/WebsocketMessages.tsx
@@ -18,9 +18,9 @@ export interface NotificationMessage {
   type: "NotificationMessage";
   title: string;
   body: string;
-  withCloseButton: boolean;
+  with_close_button: boolean;
   loading: boolean;
-  autoClose: number | boolean;
+  auto_close: number | false;
 }
 /** Clear notification message.
  *