Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NESTJS BUG] Request context not working when using FastifyAdapter #8809

Closed
4 of 15 tasks
n4an opened this issue Dec 20, 2021 · 7 comments
Closed
4 of 15 tasks

[NESTJS BUG] Request context not working when using FastifyAdapter #8809

n4an opened this issue Dec 20, 2021 · 7 comments

Comments

@n4an
Copy link

n4an commented Dec 20, 2021

Works pretty well with HTTP GET requests and with other HTTP requests that doesn't have a body. When requests have a body, the logger does not brings context and only prints the basic log message, even when log is invoked inside the request context.

  • I have searched the existing issues

Current behavior

mikro-orm/mikro-orm#2531

iamolegga/nestjs-pino#546

Minimum reproduction code

https://github.com/mittche/nest-mikro-rom

Steps to reproduce

npm i

npm run dev

Expected behavior

work as expected

Package

  • I don't know. Or some 3rd-party package
  • @nestjs/common
  • @nestjs/core
  • @nestjs/microservices
  • @nestjs/platform-express
  • @nestjs/platform-fastify
  • @nestjs/platform-socket.io
  • @nestjs/platform-ws
  • @nestjs/testing
  • @nestjs/websockets
  • Other (see below)

Other package

No response

NestJS version

No response

Packages versions

@nestjs/common": "^8.2.3

Node.js version

No response

In which operating systems have you tested?

  • macOS
  • Windows
  • Linux

Other

No response

@n4an n4an added the needs triage This issue has not been looked into label Dec 20, 2021
@kamilmysliwiec
Copy link
Member

Please, provide a minimum reproduction repository without any third-party libraries.

@kamilmysliwiec kamilmysliwiec added needs clarification and removed needs triage This issue has not been looked into labels Dec 20, 2021
@jmcdo29
Copy link
Member

jmcdo29 commented Dec 20, 2021

without any third-party libraries.
@kamilmysliwiec #8234 (comment)

@mittche there's no minimum reproduction in that issue thread. There's links to other projects that have dependencies as well, but nothing minimum, so please provide a minimum reproduction repository so we can better diagnose this

@jmcdo29
Copy link
Member

jmcdo29 commented Dec 20, 2021

For us to do anything, we need a minimum reproduction repository as we've already mentioned. I'm going to close this as we don't have one. If you can provide a reproduction, I'll re-open the issue.

@jmcdo29 jmcdo29 closed this as completed Dec 20, 2021
@n4an
Copy link
Author

n4an commented Dec 20, 2021

It is minimum. Or is to big for you :)
I'm starting to think it's intentional.
Go and buy paid support for our bugs.

I need a serious framework.
Why I not try Spring or Hibernate. Why I spent time with that ...

@jmcdo29
Copy link
Member

jmcdo29 commented Dec 20, 2021

Excuse you. None of these are minimum though. A minimum reproduction shouldn't rely on other packages to show the bug, it should be able to stand on it's own and show "Yes, this bug exists in just the framework's code". As we (the Nest team) do not own the code for MikroORM or the nestjs-pino repo, they should not be used to show the bug. Feel free to speculate all you want. All we are asking for is a simple and minimum reproduction that only uses code inside the framework and not an external package. Sorry that's too much for you to manage.

@n4an
Copy link
Author

n4an commented Dec 20, 2021

absurd, given the fact that in the nest there is nothing finite and it is always used in combination with something else

@nestjs nestjs locked as off-topic and limited conversation to collaborators Dec 20, 2021
@jmcdo29
Copy link
Member

jmcdo29 commented Dec 20, 2021

You don't want to listen and provide what we've asked, fine. Hope you're happy with Spring. We've made it clear that we expect a minimum reproduction repository. I've made it abundantly clear what that means. I hope your development career treats you well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants