-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NESTJS BUG] Request context not working when using FastifyAdapter #8809
Comments
Please, provide a minimum reproduction repository without any third-party libraries. |
@mittche there's no minimum reproduction in that issue thread. There's links to other projects that have dependencies as well, but nothing minimum, so please provide a minimum reproduction repository so we can better diagnose this |
For us to do anything, we need a minimum reproduction repository as we've already mentioned. I'm going to close this as we don't have one. If you can provide a reproduction, I'll re-open the issue. |
It is minimum. Or is to big for you :) I need a serious framework. |
Excuse you. None of these are minimum though. A minimum reproduction shouldn't rely on other packages to show the bug, it should be able to stand on it's own and show "Yes, this bug exists in just the framework's code". As we (the Nest team) do not own the code for MikroORM or the nestjs-pino repo, they should not be used to show the bug. Feel free to speculate all you want. All we are asking for is a simple and minimum reproduction that only uses code inside the framework and not an external package. Sorry that's too much for you to manage. |
absurd, given the fact that in the nest there is nothing finite and it is always used in combination with something else |
You don't want to listen and provide what we've asked, fine. Hope you're happy with Spring. We've made it clear that we expect a minimum reproduction repository. I've made it abundantly clear what that means. I hope your development career treats you well. |
Works pretty well with HTTP GET requests and with other HTTP requests that doesn't have a body. When requests have a body, the logger does not brings context and only prints the basic log message, even when log is invoked inside the request context.
Current behavior
mikro-orm/mikro-orm#2531
iamolegga/nestjs-pino#546
Minimum reproduction code
https://github.com/mittche/nest-mikro-rom
Steps to reproduce
npm i
npm run dev
Expected behavior
work as expected
Package
@nestjs/common
@nestjs/core
@nestjs/microservices
@nestjs/platform-express
@nestjs/platform-fastify
@nestjs/platform-socket.io
@nestjs/platform-ws
@nestjs/testing
@nestjs/websockets
Other package
No response
NestJS version
No response
Packages versions
@nestjs/common": "^8.2.3
Node.js version
No response
In which operating systems have you tested?
Other
No response
The text was updated successfully, but these errors were encountered: