WIP: fixing android escaping #133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 23, 2020
houndci-bot
reviewed
Jun 23, 2020
houndci-bot
reviewed
Jun 24, 2020
| def escape_android_characters(value) | ||
| value.gsub!(/'/, "'" => "\\'") | ||
| value.gsub!(/&/, "&" => '&') | ||
| value.gsub!(/</, "<" => '<') |
There was a problem hiding this comment.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
houndci-bot
reviewed
Jun 24, 2020
houndci-bot
reviewed
Jun 24, 2020
|
works on my machine :( |
added 2 commits
June 24, 2020 11:29
houndci-bot
reviewed
Jun 24, 2020
| assert_equal expected_output, output | ||
|
|
||
| assert_true FileUtils.identical?("values-en/escaped_strings.xml", | ||
| "test/data/test_data_with_characters_that_need_escaping.xml") |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [98/80]
| assert exist, "the ouptut file does not exist" | ||
|
|
||
| output = File.read("values-en/escaped_strings.xml") | ||
| expected_output = File.read("test/data/test_data_with_characters_that_need_escaping.xml") |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [93/80]
| def test_android_character_escaping | ||
| converter = Babelish::CSV2Android.new("test/data/test_data_with_characters_that_need_escaping.csv", | ||
| { "English" => "en" }, | ||
| { output_basename: "escaped_strings" }) |
There was a problem hiding this comment.
Style/BracesAroundHashParameters: Redundant curly braces around a hash parameter.
Metrics/LineLength: Line is too long. [81/80]
| @@ -69,4 +69,25 @@ def test_converting_with_basename | |||
| # clean up | |||
| system("rm -rf ./values-en") | |||
| end | |||
|
|
|||
| def test_android_character_escaping | |||
| converter = Babelish::CSV2Android.new("test/data/test_data_with_characters_that_need_escaping.csv", | |||
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [103/80]
|
|
|
There is some problems regarding already escaped charaters from the original data |
ghost
closed this by deleting the head repository
uliluckas
added a commit
to uliluckas/Babelish
that referenced
this pull request
Aug 28, 2024
Inspired by PR from Falko Richter: netbe#133
uliluckas
added a commit
to uliluckas/Babelish
that referenced
this pull request
Aug 28, 2024
Inspired by PR from Falko Richter: netbe#133
uliluckas
added a commit
to uliluckas/Babelish
that referenced
this pull request
Aug 28, 2024
Inspired by PR from Falko Richter: netbe#133
uliluckas
added a commit
to uliluckas/Babelish
that referenced
this pull request
Aug 28, 2024
Inspired by PR from Falko Richter: netbe#133
uliluckas
added a commit
to uliluckas/Babelish
that referenced
this pull request
Aug 28, 2024
Inspired by PR from Falko Richter: netbe#133
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should fix #130
<b>for instance)