Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Housekeeping - Leverage uv for python docker image builds #1385

Closed
ryanmerolle opened this issue Jan 28, 2025 · 2 comments
Closed

Housekeeping - Leverage uv for python docker image builds #1385

ryanmerolle opened this issue Jan 28, 2025 · 2 comments

Comments

@ryanmerolle
Copy link
Contributor

Desired Behavior

speed up container image builds

Contrast to Current Behavior

image builds use standard python pip installs

Required Changes

No response

Discussion: Benefits and Drawbacks

No response
@tobiasge
Copy link
Member

I did some testing and it seems to be a bit faster:

With uv:
    Building 276.2s (30/30) FINISHED
    netboxcommunity/netbox   latest            e6d47d843e0d   46 seconds ago   664MB
With pip:
    Building 535.1s (26/26) FINISHED
    netboxcommunity/netbox   latest            df88c9b28da5   40 seconds ago   700MB

tobiasge added a commit to tobiasge/netbox-docker that referenced this issue Jan 29, 2025
@tobiasge
Improved image build
222b2ba 
- Fix netbox-community#1383: Setting DEBUG = true when collection the static files
  enables the use of the Django debug toolbar.
- Fix netbox-community#1385: Use uv as package manager instead of pip speeds up the build.
@tobiasge tobiasge mentioned this issue Jan 29, 2025
Merged
3 tasks
tobiasge added a commit to tobiasge/netbox-docker that referenced this issue Feb 3, 2025
@tobiasge
Improved image build
4a33b42 
- Fix netbox-community#1383: Setting DEBUG = true when collection the static files
  enables the use of the Django debug toolbar.
- Fix netbox-community#1385: Use uv as package manager instead of pip speeds up the build.
tobiasge added a commit to tobiasge/netbox-docker that referenced this issue Feb 3, 2025
@tobiasge
Improved image build
3acfd25 
- Fix netbox-community#1383: Setting DEBUG = true when collection the static files
  enables the use of the Django debug toolbar.
- Fix netbox-community#1385: Use uv as package manager instead of pip speeds up the build.
- Nice display of Docker image version
tobiasge added a commit to tobiasge/netbox-docker that referenced this issue Feb 4, 2025
@tobiasge
Improved image build
542538b 
- Fix netbox-community#1383: Setting DEBUG = true when collection the static files
  enables the use of the Django debug toolbar.
- Fix netbox-community#1385: Use uv as package manager instead of pip speeds up the build.
- Nice display of Docker image version
@tobiasge
Copy link
Member

tobiasge commented Feb 5, 2025

Fixed in #1386

@tobiasge tobiasge closed this as completed Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tobiasge @ryanmerolle