Add default values to variables and check if set before including additional templates #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itional templates
hknezevic
force-pushed
the
url-tab-variables-check
branch
from
756e01b to
7abf8b0
Compare
|
thanks @hknezevic! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tabs in the admin UI, like URL tab, are extended (not decorated) by other Ibexa enterprise packages.
We are only decorating the location view URL tab, but adding our design ngadminui on top of adminui will use our template instead of the original one, which is in turn again reused in extended tab handlers.
If our decorator is not applied, the variables referenced in the template will not exist, and this will cause an exception in the admin UI.
I have just added default values to all the referenced variables, and wrapped the custom template includes in a conditional, so they will not be included if there is no need for it.