netlify dev leaves behind zombie processes on Windows

[kamsar]

Describe the bug

netlify dev leaves behind zombie processes on windows after ctrl-c. This leaves copies of dev tools like tsc, esbuild, nextjs, etc in watch mode running after the dev session is terminated.

To Reproduce

Steps to reproduce the behavior:

https://github.com/kamsar/nfcli-sigint-zombies#readme

Configuration

See repro repository above for steps and reproducible scenario. Tests ran on Windows 10 19042, node 14.15.4, npm and yarn both. It seems to occur on any process spawned by netlify dev - tsc, npm-run-all, esbuild, node scripts, etc.

Expected behavior

netlify-dev should not leave behind zombie processes - and it did not used to, this started happening a month or two ago.

[erezrokah]

Probably related to

cli/src/commands/dev/index.js

Line 92 in f5743f0

frameworkProcess.kill('SIGTERM', { forceKillAfterTimeout: 500 })

[kamsar]

@erezrokah I did mess around with that line a bit to see if I could get it to work before submitting the issue, but it seemed resistant to the things I tried: firing SIGINT instead of SIGTERM, passing on the same signal that came in (except exit which is not a signal), and passing on only SIGINT in case it was triggered by multiple events in sequence (SIGINT, exit).

[joshmossas]

I've been having this same issue.

To deal with this I've been running the following in my CLI after killing netlify dev to manually kill all nodejs processes

 taskkill /F /IM node.exe /T

[erezrokah]

@erezrokah I did mess around with that line a bit to see if I could get it to work before submitting the issue, but it seemed resistant to the things I tried: firing SIGINT instead of SIGTERM, passing on the same signal that came in (except exit which is not a signal), and passing on only SIGINT in case it was triggered by multiple events in sequence (SIGINT, exit).

Thanks @kaganjd, if you feel like messing with this a bit more, maybe using kill-tree can help. We use it in our tests

cli/tests/utils/process.js

Line 5 in 5026e02

kill(ps.pid)

[Xenonym]

The issue is that execa defaults to windowsHide: true, which seems to interfere with terminating child processes: sindresorhus/execa#433. Setting windowsHide: false would fix the issue.

Other projects have also encountered this issue with execa's defaults and Windows: FredKSchott/snowpack#1022, lerna/lerna#2946.

[ehmicky]

Thanks @Xenonym for fixing this in #3278 🎉

This has been released with 6.8.1.

[kamsar]

Can confirm 6.8.1 works for me. Much appreciated! :)