-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tag for PHP 8.4 support #68
Comments
You can't be sure that release is compatible with PHP 8.4 until stable version of PHP 8.4 is released (or is at least very close). To ensure compatibility, it is better to wait. |
Maybe it's indeed better to wait for an RC release but I suggest tagging a compatible version when that happens. If you wait until the actual release of PHP 8.4 then every upstream dependent library is blocked from releases PHP 8.4 versions as well and thus end users are blocked as well. It's best to do these releases in advance but I agree with you that during the beta period it might be a bit too soon. |
If RC version works, then it may indeed be the right time to do the release. |
@dg thank you. We are aware of that and have used it in the past but as I stated above this is about full stable support for PHP 8.4 on Laravel. Without a tag on this library that isn't possible I'm afraid. Again, more than happy to let this wait until a first RC 👍 |
Just a heads-up that the first RC for PHP 8.4 is now released; this should mean it's stable enough to tag this package as compatible if it passes all tests on this version. |
version 1.3.1 supports PHP 8.4 |
Can we get a tag for PHP 8.4 support? Seems it's already landed but just awaiting a release: v1.3.0...master
That would help us get to PHP 8.4 support in Laravel: laravel/framework#52633
The text was updated successfully, but these errors were encountered: