Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tag when pushing to main #18

Closed
glazychev-art opened this issue Nov 8, 2023 · 2 comments
Closed

Add tag when pushing to main #18

glazychev-art opened this issue Nov 8, 2023 · 2 comments
Assignees

Comments

@glazychev-art
Copy link

Description

Currently, we only tag images:
ghcr.io/networkservicemesh/govpp/vpp:v23.10-rc0-166-g4a6d39d90

It is also necessary to tag the commit from which this image was built.

@VitalyGushin
Copy link
Collaborator

VitalyGushin commented Feb 20, 2024

Action plan for including govpp into the NSM release:

  1. Add vpp version tagging for commit on every push into main branch
  2. Add release workflow (support usual tagging with NSM release version)
  3. Don’t exclude /govpp package from go.mod dependencies (check-gomod-deps.yaml)

Example:

  1. Any push into main:
    a. Tag the last commit with the last vpp version like v23.10-rc0-169-g7e1c880d6
    b. Build the govpp/vpp image and tag it with the last vpp version like v23.10-rc0-169-g7e1c880d6
  2. Release:
    a. Create a release branch like release/v1.12.0
    b. Tag the last commit with a release version like v1.12.0
    c. Build the govpp/vpp image and tag it with a release version like v1.12.0

cc @edwarnicke @denis-tingaikin @glazychev-art

@denis-tingaikin denis-tingaikin moved this from Under review to In Progress in Release v1.13.0 Feb 20, 2024
@denis-tingaikin denis-tingaikin moved this from In Progress to Blocked in Release v1.13.0 Feb 20, 2024
@glazychev-art glazychev-art moved this from Blocked to In Progress in Release v1.13.0 Feb 29, 2024
@glazychev-art glazychev-art moved this from In Progress to Under review in Release v1.13.0 Feb 29, 2024
@VitalyGushin VitalyGushin moved this from Under review to In Progress in Release v1.13.0 Mar 13, 2024
@glazychev-art glazychev-art moved this from In Progress to Under review in Release v1.13.0 Mar 19, 2024
@VitalyGushin VitalyGushin moved this from Under review to Done in Release v1.13.0 Apr 3, 2024
@denis-tingaikin
Copy link
Member

Seems like the scope is done.

Can be improved in the future #40
Also, nice to do #41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

4 participants