Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move go generate diff check into a separate job. #36

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

VitalyGushin
Copy link
Collaborator

#30

@VitalyGushin VitalyGushin force-pushed the move-go-generate-diff-check-to-a-separate-job branch from d2d8295 to 353a633 Compare March 14, 2024 13:23
@VitalyGushin VitalyGushin force-pushed the move-go-generate-diff-check-to-a-separate-job branch from 353a633 to d4a3d05 Compare March 14, 2024 14:33
@glazychev-art
Copy link

@VitalyGushin
Check generated files failed, but it should be green.
Do you have any idea?

I guess it is related to the diff, which actually looks like this:
https://github.com/networkservicemesh/govpp/actions/runs/8252757728/job/22573172614#step:7:15

-//  VPP:              23.10-rc0~170-g6f1548434
+//  VPP:              23.10-rc0~170-gfb4b9fae3

Can we skip these lines somehow?

@VitalyGushin
Copy link
Collaborator Author

@glazychev-art
The new job failed because it works ("go generate" produces diff). I may run "go generate" locally and add these changes to the PR to make the job green.

Signed-off-by: Vitaliy Guschin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants