-
-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ecomode_addon-2 #2684
base: master
Are you sure you want to change the base?
ecomode_addon-2 #2684
Conversation
Signed-off-by: DaRK AnGeL <[email protected]>
Signed-off-by: DaRK AnGeL <[email protected]>
❌ Build nut 2.8.2.2368-master failed (commit e298656580 by @masterwishx) |
✅ Build nut 2.8.2.2369-master completed (commit 813fcec36b by @masterwishx) |
Signed-off-by: DaRK AnGeL <[email protected]>
Signed-off-by: DaRK AnGeL <[email protected]>
@arnaudquette-eaton Very sorry to bother you again ,maybe you can find info about:
|
no need to be sorry @masterwishx , I'm always happy to help ;) Desc: Item of Bypass AC Input collection RW 0: The automatic transfer on bypass is not allowed Hope it helps |
Thanks a lot , so its like as you know we now have ECO/Bypass enabled with your help for HID info! the only problem i cant exit from ECO to bypass by r/w values or commands bypass.on/off , but maybe its local issue for my UPS with timeouts .... Also will try to add function for auto enter to ECO mode ( bypass.on + ECO + bypass.off) but still cant test exit from ECO :( |
Signed-off-by: DaRK AnGeL <[email protected]>
Signed-off-by: DaRK AnGeL <[email protected]>
added values if you think they usefull ? |
❌ Build nut 2.8.2.2373-master failed (commit 87e718f5df by @masterwishx) |
Signed-off-by: DaRK AnGeL <[email protected]>
Signed-off-by: DaRK AnGeL <[email protected]>
Signed-off-by: DaRK AnGeL <[email protected]>
✅ Build nut 2.8.2.2374-master completed (commit 09443bb338 by @masterwishx) |
Signed-off-by: DaRK AnGeL <[email protected]>
Signed-off-by: DaRK AnGeL <[email protected]>
Signed-off-by: DaRK AnGeL <[email protected]>
Signed-off-by: DaRK AnGeL <[email protected]>
Signed-off-by: DaRK AnGeL <[email protected]>
Signed-off-by: DaRK AnGeL <[email protected]>
CC @arnaudquette-eaton can you please check and confirm that we can exit from ECO mode by : |
Signed-off-by: DaRK AnGeL <[email protected]>
Signed-off-by: DaRK AnGeL <[email protected]>
Signed-off-by: DaRK AnGeL <[email protected]>
Signed-off-by: DaRK AnGeL <[email protected]>
❌ Build nut 2.8.2.2383-master failed (commit 985fb4d495 by @masterwishx) |
✅ Build nut 2.8.2.2386-master completed (commit 72fd7b8e62 by @masterwishx) |
❌ Build nut 2.8.2.2387-master failed (commit d98bf537da by @masterwishx) |
IFrom 8afba96 Another easy method just to make bash script with (bypass.start,ecomode.enable etc... ) |
✅ Build nut 2.8.2.2389-master completed (commit 594d32a999 by @masterwishx) |
drivers/mge-hid.c
Outdated
@@ -909,21 +908,26 @@ static const char *eaton_input_eco_mode_auto_on_fun(double value) | |||
} | |||
|
|||
/* Check if input.eco.switchable is normal and set it to 'ECO' */ | |||
if (strcmp(eco_switchable_str, "normal")) { | |||
if (strcmp(eco_switchable_str, "normal")) { | |||
check_eco_result = eaton_input_eco_mode_check_range(value); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jimklimov please confirm here we should call function to check range becouse :
when setvar("input.eco.switchable", "ECO");
its only set variable but not calling function eaton_input_eco_mode_check_range
like here, same for bypass?
Lines 1709 to 1710 in 858f615
/* ECO(HE), ESS Mode switch, to use when 'input.bypass.switch.on' is on */ | |
{ "input.eco.switchable", ST_FLAG_RW | ST_FLAG_STRING, 8, "UPS.PowerConverter.Input.[5].Switchable", NULL, "%.0f", HU_FLAG_SEMI_STATIC, eaton_input_eco_mode_on_off_info }, |
Lines 783 to 789 in 858f615
/* High Efficiency (aka ECO) mode, Energy Saver System (aka ESS) mode makes sense for UPS like (93PM G2, 9395P) */ | |
static info_lkp_t eaton_input_eco_mode_on_off_info[] = { | |
{ 0, "normal", NULL, NULL }, | |
{ 1, "ECO", eaton_input_eco_mode_check_range, NULL }, /* NOTE: "ECO" = tested on 9E model and working fine */ | |
{ 2, "ESS", NULL, NULL }, | |
{ 0, NULL, NULL, NULL } | |
}; |
@arnaudquette-eaton please confirm that seems setvar also call info_lkp_t *<unnamed>::hid2info
so no need to call this function befor like i wrote above ?
Lines 969 to 972 in b624145
/* Lookup the new value if needed */ | |
if (hidups_item->hid2info != NULL) { | |
value = hu_find_valinfo(hidups_item->hid2info, val); | |
} else { |
❌ Build nut 2.8.2.2392-master failed (commit 97b0d1f4b5 by @masterwishx) |
✅ Build nut 2.8.2.2393-master completed (commit d3d37865f4 by @masterwishx) |
✅ Build nut 2.8.2.2396-master completed (commit 39078e0566 by @masterwishx) |
@arnaudquette-eaton Sorry again but can you check and confirm that it was done right ?
or we should use :
|
dd414bf
to
22a9d85
Compare
❌ Build nut 2.8.2.2406-master failed (commit b70396de2e by @masterwishx) |
Signed-off-by: DaRK AnGeL <[email protected]>
Signed-off-by: DaRK AnGeL <[email protected]>
✅ Build nut 2.8.2.2415-master completed (commit 2870c688e1 by @masterwishx) |
add-on for #2637,#2680 ECO/Bypass for Eaton Models
@jimklimov In this new pr we can:
You think we can add ESS stuff also, however
Only enterprise UPSes have it?
[ Done ] We can add also post limits not passed in debug when check range eco/bypass func.
[ Done ] added variables:
CC @jimklimov please confirm if it needed .
Also for now can't leave eco mode by commands but maybe Becouse my ussue with timeout, not sure...