Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetXMS WebUI with jetty, DOC-62 #23

Closed
wants to merge 3 commits into from
Closed

Conversation

ua0088
Copy link
Contributor

@ua0088 ua0088 commented Dec 12, 2024

No description provided.

@alkk
Copy link
Member

alkk commented Dec 12, 2024

Files in cdb594d were converted to windows line endings.
Simplest solution:

  • git revert cdb594d
  • then squash before merge

Also check core.autocrlf switch, maybe it's configured incorrectly (https://docs.github.com/en/get-started/getting-started-with-git/configuring-git-to-handle-line-endings#global-settings-for-line-endings)

@ua0088 ua0088 force-pushed the DOC-62 branch 2 times, most recently from ce31888 to a4ba8d4 Compare December 12, 2024 15:49

curl -O https://repo1.maven.org/maven2/org/eclipse/jetty/jetty-home/12.0.13/jetty-home-12.0.13.tar.gz

2. Prepare jetty installation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is jetty installation step, not preparation for installation

alkk added a commit that referenced this pull request Jan 6, 2025
@alkk
Copy link
Member

alkk commented Jan 6, 2025

Merged in a9b7c83

@alkk alkk closed this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants