Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special characters in tag and attribute names #110

Open
mikeyhew opened this issue Feb 24, 2016 · 2 comments
Open

Special characters in tag and attribute names #110

mikeyhew opened this issue Feb 24, 2016 · 2 comments

Comments

@mikeyhew
Copy link

The following examples are both rendering wrong:

%ul
  / Breaks because of asterisk (*)
  %li(*ngFor="#i in [1,2,3]")
    This is tag number {{i}}.
/ non-ascii characters
%my-tág
@vendethiel
Copy link
Collaborator

The first one seems "correct" to me, but maybe we should be able to quote attibutes.

The second one is probably a regexp that's a tad too simple, i'd gladly accept a PR with a test that fixes it :).

@mikeyhew
Copy link
Author

Alright, I'll see if I can get around to it :). Hopefully it won't impact performance too badly. What do you think about just supporting every valid XML name for tag and attribute names, as described here and referenced in the HTML spec here?

Re the first example, that's the new Angular 2.0 syntax, and I'm not even sure it's valid HTML. If I end up using these together in my workflow, I'll probably create a fork that supports a * in front of attribute names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants