Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set a favicon #19

Open
hantuzun opened this issue Feb 9, 2023 · 4 comments
Open

Set a favicon #19

hantuzun opened this issue Feb 9, 2023 · 4 comments
Labels
design help needed enhancement New feature or request good first issue no code Issues for contributors without technical skills

Comments

@hantuzun
Copy link
Contributor

hantuzun commented Feb 9, 2023

No description provided.

@hantuzun hantuzun added enhancement New feature or request no code Issues for contributors without technical skills good first issue design help needed labels Feb 9, 2023
cankarakoyun added a commit to cankarakoyun/turkiye-relief-dao that referenced this issue Feb 12, 2023
@cankarakoyun
neu-fi#19 review important! I added new favico using the desing on ne…
ef102eb 
…u-fi#14. Please check if it's okay. Just a suggestion.
hantuzun added a commit that referenced this issue Feb 12, 2023
@hantuzun
Merge pull request #44 from cankarakoyun/19-favico
bd2f9bb 
#19 review important!
@hantuzun
Copy link
Contributor Author

We have got a favicon now.

However, we better have a favicon designed for the purpose.

The favicon also better be optimized for different devices: https://favicon.io/favicon-converter/

@TeenaBatra
Copy link
Collaborator

@hantuzun Can I take this up? 👆

@TeenaBatra TeenaBatra mentioned this issue Feb 12, 2023
Closed
@hantuzun
Copy link
Contributor Author

Hi @TeenaBatra, you were on the right path but used Vercel's logo. We'll vote for our logo tomorrow and feel free to open this issue again. Did you previously use favicon.io?

Please confirm your Vercel deployment with one of the favicon verification websites afterward.

@TeenaBatra
Copy link
Collaborator

Hey @hantuzun, Ohh, yeah I used the favicon.ico that was present in the project. My bad, I thought it was your logo and didn't realize it's Vercel's logo. Sure, will open this issue again once the logo is finalized.
Thanks for pointing out this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design help needed enhancement New feature or request good first issue no code Issues for contributors without technical skills
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hantuzun @TeenaBatra