Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conflicting types in BookForm #18

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

esgoet
Copy link
Contributor

@esgoet esgoet commented Aug 19, 2024

Changed NewBook to BookWithoutId
Changed BookForm to only expect BookWithoutId

Copy link
Contributor

@SimonSta95 SimonSta95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@marcelherr marcelherr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Aug 19, 2024

Quality Gate Passed Quality Gate passed for 'neuefische_hh-java-24-3-teamproject-team-2-frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Aug 19, 2024

Quality Gate Passed Quality Gate passed for 'neuefische_hh-java-24-3-teamproject-team-2-backend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@esgoet esgoet merged commit 0e2fc35 into main Aug 19, 2024
5 checks passed
@esgoet esgoet deleted the Feat/make-details-edit-form branch August 19, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants