Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R1: Notebook # 0 #12

Open
mathieuboudreau opened this issue Jul 18, 2019 · 1 comment
Open

R1: Notebook # 0 #12

mathieuboudreau opened this issue Jul 18, 2019 · 1 comment

Comments

@mathieuboudreau
Copy link
Member

mathieuboudreau commented Jul 18, 2019

Assignee: @manojneuro

Notebook # 0

  • For easier long term maintenance of this notebook, I'd recommend you divide the imports by section in terms of notebook number (or even, one cell per all import for each notebook). That way if you update a notebook's import in the future, you'll know where to add them in this test file, and if one of them fails, you'll have better information of which notebook(s) will be affected.
  • A warning is thrown for sklearn; one of the imported module will be depricated in version 0.23 (currently on 0.21). If you don't fix the version of sklearn installed, some of your users may have problems in the issue if a docker image cache is cleared and/or new build is executed. Some text from yourselves acknowledging this warning to reassure the user that this warning is expected and won't impact their tutorial experience may be valuable.
@mathieuboudreau mathieuboudreau changed the title R1: Notebook #0 R1: Notebook # 0 Jul 18, 2019
@pbellec
Copy link
Member

pbellec commented Aug 26, 2019

@manojneuro any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants