Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicit repeat of dataset before calling fit method #314

Open
hvgazula opened this issue Apr 1, 2024 · 2 comments
Open

explicit repeat of dataset before calling fit method #314

hvgazula opened this issue Apr 1, 2024 · 2 comments
Assignees
Labels
Milestone

Comments

@hvgazula
Copy link
Contributor

hvgazula commented Apr 1, 2024

For reasons described here and discussed elsewhere, I suggest repeat should be called before fit and not before performing any map operations in the Dataset class, which is redundant.

@hvgazula hvgazula added the bug label Apr 1, 2024
@hvgazula hvgazula self-assigned this Apr 1, 2024
@satra
Copy link
Contributor

satra commented Apr 1, 2024

aren't these all generators?

@hvgazula
Copy link
Contributor Author

hvgazula commented Apr 1, 2024

technically yes, but by the time dataset_train.scalar_labels is called the dataset is repeated already making any operations repetitive and redundant.

hvgazula added a commit that referenced this issue Apr 1, 2024
also disable calculating scalar_labels, for more info #313
hvgazula added a commit that referenced this issue Apr 2, 2024
also disable calculating scalar_labels, for more info #313
@hvgazula hvgazula added this to the 1.2.1 milestone Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants