Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch models from https://modeldb.science/ #88

Merged
merged 6 commits into from
Jun 21, 2023
Merged

Fetch models from https://modeldb.science/ #88

merged 6 commits into from
Jun 21, 2023

Conversation

olupton
Copy link
Collaborator

@olupton olupton commented Jun 21, 2023 •
edited
Loading

  • Stop fetching from the Yale website.
  • Improve cache management
    • Always make two bulk API calls to get all NEURON model IDs and their last-modification timestamps.
    • Use those timestamps to decide whether the given (or all) models need to be re-downloaded.

Closes #82.

alexsavulescu
alexsavulescu approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@alexsavulescu alexsavulescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olupton olupton marked this pull request as ready for review June 21, 2023 15:01
ramcdougal
ramcdougal reviewed Jun 21, 2023
View reviewed changes
modeldb/config.py Outdated Show resolved Hide resolved
@alexsavulescu alexsavulescu merged commit 98587d9 into master Jun 21, 2023
@alexsavulescu alexsavulescu deleted the olupton/model-src branch June 21, 2023 21:19
@olupton olupton mentioned this pull request Jul 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexsavulescu alexsavulescu alexsavulescu approved these changes

@ramcdougal ramcdougal ramcdougal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MDB_MODEL_DOWNLOAD_URL needs to be updated
3 participants
@olupton @ramcdougal @alexsavulescu