Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand scope of NRN_AVOID_ABSOLUTE_PATHS #3310

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JCGoran
Copy link
Collaborator

@JCGoran JCGoran commented Jan 16, 2025

Part 1 towards #3309.
If NRN_AVOID_ABSOLUTE_PATHS=ON, only the filename is now inserted in the generated mod files (some parts were missing before).
Note that this is not the default setting so it has no effect on releases.

Copy link

Copy link

✔️ 73b20fe -> Azure artifacts URL

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.07%. Comparing base (74dcdd5) to head (73b20fe).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3310   +/-   ##
=======================================
  Coverage   67.07%   67.07%           
=======================================
  Files         571      571           
  Lines      111055   111056    +1     
=======================================
+ Hits        74488    74489    +1     
  Misses      36567    36567           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JCGoran JCGoran marked this pull request as ready for review January 16, 2025 15:18
@JCGoran JCGoran requested a review from nrnhines January 16, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants