Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter alpha (q) is not being used by the FDR correction method #115

Open
JulioAPeraza opened this issue Mar 23, 2023 · 0 comments
Open
Labels
bug Something isn't working

Comments

@JulioAPeraza
Copy link
Collaborator

The parameter q is passed to fdr but it's not used:

PyMARE/pymare/stats.py

Lines 178 to 188 in 604bb4f

def fdr(p_values, q=0.05, method="bh"):
"""Perform FDR correction on p values.
.. versionadded:: 0.0.4
Parameters
----------
p_values : :obj:`numpy.ndarray`
Array of p values.
q : :obj:`float`, optional
Alpha value. Default is 0.05.

@JulioAPeraza JulioAPeraza added the bug Something isn't working label Mar 23, 2023
@JulioAPeraza JulioAPeraza changed the title Parameter alpha (q) is not been used by the FDR correction method Parameter alpha (q) is not being used by the FDR correction method Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant