pylint

neutrons · May 20, 2024 · db7237c · db7237c
1 parent 30e625f
commit db7237c
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/src/shiver/models/histogram.py b/src/shiver/models/histogram.py
@@ -65,6 +65,7 @@ def load(self, filename, ws_type):
             additional_parameters = {"LoadHistory": False}
         else:
             logger.error(f"Unsupported workspace type {ws_type} for {filename}")
+            return
 
         endrange = 100
         progress = Progress(load, start=0.0, end=1.0, nreports=endrange)

diff --git a/src/shiver/views/histogram_parameters.py b/src/shiver/views/histogram_parameters.py
@@ -871,10 +871,6 @@ def min_max_compare(self, cmin, cmax):
                 self.set_field_invalid_state(cmax)
                 self.min_max_invalid_states.append(cmax)
 
-        else:
-            # it should never be here
-            return
-
     def min_max_checked(self, cmin, cmax):
         """Ensure Minimum and Maximum value pairs are:
         float numbers, Minimum < Maximum and both exist at the same time"""