Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facility Set - Sample Log Saving - Save/LoadUB - Imports and minor issues #129

Merged
merged 8 commits into from
May 7, 2024

Conversation

mpatrou
Copy link
Collaborator

@mpatrou mpatrou commented May 7, 2024

Short description of the changes:

The code includes the following changes:

  • set facility to SNS (some cleanup too)
  • add algorithms to Shiver category in Mantidworkbench
  • save sample logs in the mdhistogram with options set in the config file
  • change Mantid version in conda environment
  • load UB from nexus for mdworkspaces.
  • save UB as ISAW
  • imports of Mantid algorithms defined in Shiver for pytest to avoid crashes of single tests

Related tests are added.

Long description of the changes:

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

@mpatrou mpatrou force-pushed the v1_minor_issues branch from 3a88ddc to 33b4af2 Compare May 7, 2024 15:21
@mpatrou mpatrou changed the title Facility Set - Sample Log Saving - LoadUB - Imports and minor issues Facility Set - Sample Log Saving - Save/LoadUB - Imports and minor issues May 7, 2024
@AndreiSavici AndreiSavici merged commit 23b651e into next May 7, 2024
4 checks passed
@AndreiSavici AndreiSavici deleted the v1_minor_issues branch May 7, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants