From c77e68fa21039d25207ce0fb4c0753f235ecb29a Mon Sep 17 00:00:00 2001 From: Evan Mullins Date: Tue, 5 Nov 2024 17:35:41 -0500 Subject: [PATCH 1/2] update migration tests add a small wait for the app to open the help-center use more specific targets for the close button. --- tests/cypress/integration/Home/migration.cy.js | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tests/cypress/integration/Home/migration.cy.js b/tests/cypress/integration/Home/migration.cy.js index 5847f77c..69a45d69 100644 --- a/tests/cypress/integration/Home/migration.cy.js +++ b/tests/cypress/integration/Home/migration.cy.js @@ -37,13 +37,13 @@ describe( cy.get( '.nfd-justify-start', { timeout: customCommandTimeout } ) .scrollIntoView() .should( 'exist' ); - } ); + } ); it( 'Verify if One last thing to do... section shows', () => { cy.get( '#next-steps-section', { timeout: customCommandTimeout } ) .scrollIntoView() .should( 'exist' ); - } ); + } ); it( 'Verify when update nameserver clicked', () => { cy.intercept( APIList.update_nameserver ).as( 'events' ); @@ -57,7 +57,8 @@ describe( cy.get( '.help-container', { timeout: customCommandTimeout, } ).should( 'be.visible' ); - cy.get( '.close-button' ).click(); + cy.wait( 1000 ); + cy.get( '.help-container button.close-button' ).click(); } ); it( 'Verify when connect domain to site clicked', () => { @@ -72,7 +73,8 @@ describe( cy.get( '.help-container', { timeout: customCommandTimeout, } ).should( 'be.visible' ); - cy.get( '.close-button' ).click(); + cy.wait( 1000 ); + cy.get( '.help-container button.close-button' ).click(); } ); it( 'Verify when continue with store setup clicked', () => { From a09dd53fd784886d5620e799d43e5cdc2040e0c6 Mon Sep 17 00:00:00 2001 From: Evan Mullins Date: Tue, 5 Nov 2024 17:39:22 -0500 Subject: [PATCH 2/2] use get timeout rather than wait --- tests/cypress/integration/Home/migration.cy.js | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tests/cypress/integration/Home/migration.cy.js b/tests/cypress/integration/Home/migration.cy.js index 69a45d69..d7a22759 100644 --- a/tests/cypress/integration/Home/migration.cy.js +++ b/tests/cypress/integration/Home/migration.cy.js @@ -57,8 +57,9 @@ describe( cy.get( '.help-container', { timeout: customCommandTimeout, } ).should( 'be.visible' ); - cy.wait( 1000 ); - cy.get( '.help-container button.close-button' ).click(); + cy.get( '.help-container button.close-button', { + timeout: 5000, + } ).click(); } ); it( 'Verify when connect domain to site clicked', () => { @@ -73,8 +74,9 @@ describe( cy.get( '.help-container', { timeout: customCommandTimeout, } ).should( 'be.visible' ); - cy.wait( 1000 ); - cy.get( '.help-container button.close-button' ).click(); + cy.get( '.help-container button.close-button', { + timeout: 5000, + } ).click(); } ); it( 'Verify when continue with store setup clicked', () => {