Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use appId for selector #74

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Conversation

circlecube
Copy link
Member

Proposed changes

Tweak the new product page test to be compatible with other brand plugins using the appId for element selector. The test currently passes for bluehost, but fails for other brand plugins.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube circlecube requested a review from wpalani June 26, 2024 18:44
@circlecube circlecube self-assigned this Jun 26, 2024
@circlecube
Copy link
Member Author

Merging this as it fixes module-based tests to work in all brands, but to get all passing tests in brand plugins they each need to update the marketplace integration (bluehost is complete).

@circlecube circlecube merged commit 4f236a7 into main Jun 26, 2024
2 of 6 checks passed
@circlecube circlecube deleted the fix/product-page-test-for-other-brands branch June 26, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants