Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Optimization: Add Lazy Loading Support #32

Open
wants to merge 4 commits into
base: enhance/PRESS7-81-intercept-media-upload
Choose a base branch
from

Conversation

arunshenoy99
Copy link
Member

@arunshenoy99 arunshenoy99 commented Nov 27, 2024

Proposed changes

Story: https://jira.newfold.com/browse/PRESS7-76

  • Adds a new setting to enable lazy loading for images under the Image Optimization tab.
  • Implements a two-layer approach:
    1. Backend:
      • Adds the loading="lazy" attribute to images and avatars directly in the generated HTML.
    2. Frontend:
      • A JavaScript listener applies the loading="lazy" attribute to dynamically added elements in the DOM.

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

lazy-loading.mp4

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@bradp bradp mentioned this pull request Dec 11, 2024
6 tasks
@arunshenoy99 arunshenoy99 changed the title Add Lazy Loading Support Image Optimization: Add Lazy Loading Support Dec 19, 2024
@arunshenoy99 arunshenoy99 added the enhancement New feature or request label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant