Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging around invalid license key #2969

Open
neilpdx opened this issue Jan 24, 2025 · 1 comment
Open

Improve logging around invalid license key #2969

neilpdx opened this issue Jan 24, 2025 · 1 comment
Labels
community To tag external issues and PRs

Comments

@neilpdx
Copy link
Contributor

neilpdx commented Jan 24, 2025

Is your feature request related to a problem? Please describe.

The current logging when a license key is invalid is misleading, causing confusion for customers and Support.

Currently, when a license key has a default value of REPLACE_WITH_LICENSE_KEY or a blank value, a log message includes the helpful message "Please set your license key."

When an invalid value is set, the agent logs a message similar to the following:

NewRelic  ERROR: [pid, tid] Request(): Received HTTP status code Unauthorized with message {}. Request content was: [{"high_security":false}]

NewRelic  ERROR: [pid, tid] Unable to connect to the New Relic service at collector.newrelic.com:443
NewRelic.Agent.Core.DataTransport.HttpException: {}
   at NewRelic.Agent.Core.DataTransport.HttpCollectorWire.ThrowExceptionFromHttpResponseMessage(String serializedData, HttpStatusCode statusCode, String responseText, Guid requestGuid)
   at NewRelic.Agent.Core.DataTransport.HttpCollectorWire.SendData(String method, ConnectionInfo connectionInfo, String serializedData, Guid requestGuid)
   at NewRelic.Agent.Core.DataTransport.ConnectionHandler.SendDataOverWire[T](ICollectorWire wire, String method, Object[] data)
   at NewRelic.Agent.Core.DataTransport.ConnectionHandler.SendNonDataRequest[T](String method, Object[] data)
   at NewRelic.Agent.Core.DataTransport.ConnectionHandler.SendPreconnectRequest()
   at NewRelic.Agent.Core.DataTransport.ConnectionHandler.Connect()
   at NewRelic.Agent.Core.DataTransport.ConnectionManager.Connect()
NewRelic   INFO: [pid, tid] Connection failed: {}
NewRelic   INFO: [pid, tid] Will attempt to reconnect in 60 seconds

The mention of "high_security" is misleading, as this is included whether or not the account is a high security account.

Additionally, it's not clear that the problem is related to the invalid license key or some other network issue.

Feature Description

Improve logging so that when an invalid license key is being used, that is noted in the message.

For example, something like this would be more helpful:

NewRelic  ERROR: [pid, tid] Request(): Received HTTP status code Unauthorized. The current license key with prefix (abcd...) was unable to be validated. Please make sure you've set a valid ingest license key.

Priority

Really Want

@workato-integration
Copy link

@github-actions github-actions bot added the community To tag external issues and PRs label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community To tag external issues and PRs
Projects
None yet
Development

No branches or pull requests

1 participant