Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support For role: service #370

Open
si-c613 opened this issue Mar 7, 2024 · 1 comment
Open

Add Support For role: service #370

si-c613 opened this issue Mar 7, 2024 · 1 comment
Labels
feature request Categorizes issue or PR as related to a new feature or enhancement.

Comments

@si-c613
Copy link

si-c613 commented Mar 7, 2024

Description

Prometheus supports Kubernetes service discovery for more roles than just Pod and Endpoint.
We have a use case for some applications which all report the same metric so we only want to scrape the Service rather than each Endpoint or Pod.

Acceptance Criteria

Add support for service: true to be set inside the kubernetes discovery config.

Helm values:

config:
  kubernetes:
    jobs:
      - job_name_prefix: default
        target_discovery:
          service: true # <---- new config value
          filter:
            annotations:
              prometheus.io/scrape-service: true

Prometheus config:

  kubernetes_sd_configs:
  - role: service
    kubeconfig_file: ""
    follow_redirects: true
    enable_http2: true

Describe Alternatives

Configure static_targets

Dependencies

documentation will need updating

Additional context

NA

Estimates

S = 1-3 days

For Maintainers Only or Hero Triaging this bug

Suggested Priority (P1,P2,P3,P4,P5):
Suggested T-Shirt size (S, M, L, XL, Unknown):

@si-c613 si-c613 added the feature request Categorizes issue or PR as related to a new feature or enhancement. label Mar 7, 2024
@workato-integration
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Categorizes issue or PR as related to a new feature or enhancement.
Projects
None yet
Development

No branches or pull requests

1 participant