Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nri-config-generator] cli, env var support #72

Open
paologallinaharbur opened this issue Jul 8, 2021 · 2 comments
Open

[nri-config-generator] cli, env var support #72

paologallinaharbur opened this issue Jul 8, 2021 · 2 comments

Comments

@paologallinaharbur
Copy link
Member

The support for both cli and env var is custom and possibly fragile, we could:

  • move it to Viper (config file is already managed with such library)
  • use integration SDK (it would be more "standard" with respect to existing integrations)
@paologallinaharbur paologallinaharbur added the feature request Categorizes issue or PR as related to a new feature or enhancement. label Jul 8, 2021
@kang-makes kang-makes assigned kang-makes and unassigned kang-makes Sep 12, 2022
@paologallinaharbur
Copy link
Member Author

This task is referring to the env management of the configurator itself, not of the integrations.

Example of code not having a standard management of environment variables:

@davidgit davidgit removed the feature request Categorizes issue or PR as related to a new feature or enhancement. label Oct 21, 2022
@workato-integration
Copy link

https://issues.newrelic.com/browse/NEWRELIC-4716

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@davidgit @paologallinaharbur @kang-makes